feat: add profile and contacts fetching from pubky#824
feat: add profile and contacts fetching from pubky#824ben-kaufman wants to merge 36 commits intomasterfrom
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
app/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
app/src/main/java/to/bitkit/ui/screens/profile/ProfileViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/profile/PubkyRingAuthViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/profile/ProfileScreen.kt
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Starting review |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Few issues/comments found during testing:
The capabilities in PubkyService are hardcoded to For dev/tnet/E2E builds we should be using staging.pubky.app / staging.paykit.app instead — Pubky Ring already distinguishes between staging and production based on homeserver. This will be needed for E2E test automation.
After hitting a profile load failure (possibly related to the staging mismatch above), the app gets stuck on an "Unable to load profile" screen with no way to disconnect/sign out. Resetting wallet and wiping app data from system settings do not clear it - only a full reinstall works. The session seems to persist somewhere that survives both of those operations (Keychain?). Screen_Recording_20260313_185242_Bitkit.Regtest.mp4
|
|
Also My profile in Contacts does not show profile details as opposed to iOS (checked on latest revision 78d16f7), also already mentioned by Ovi: Screen.Recording.2026-03-16.at.14.03.24.mov |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
What is the best way to testing this? A Pubky Ring on staging? |
This comment was marked as outdated.
This comment was marked as outdated.
From what I see staging doesn't work still? Or maybe it is because of HTTP-auth required on staging 🤔 (IMO we should solve this and allow testing on staging): Screen.Recording.2026-03-16.at.18.22.17.mov |
Actually started to work after I http-auth'ed to staging.pubky.app in browser... 🤷 👍 |
…x contacts grouping and navigation
refactor: migrate pubky images to coil
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
This version works for me 🙌🏻
IDK… but the way I test it is Pubky Ring on prod + bitkit app on Regtest 🤷🏻 Is it supposed not to work? xD Maybe… but it does 🙃 |
It seems pubky ring supports multiple pubkys on different homeservers in the same app. I could test with staging and prod pubky on the same ring installation. |
I use pubky ring with the pubky I use for pubky.app, so that should be auth-scoped to prod :). of course, prod ring supports testnet pubkys also 👍🏻 what I was trying to say is that you (ie anyone willing to test) doesn't need anything staging-like for ring, just use prod ring with your prod pubky that you're supposed to have in it. But then I was wondering if this is ok 🤷🏻 |
4 participants
Integrates Pubky decentralized identity into Bitkit, adding profile authentication, a contacts screen.
What's included
Pubky profile
pubkyauth://) with relay-based session exchange, session persistence in Keychain, and automatic session restoration on launchPubkyService— service layer wrappingpaykit(session management) andbitkit-core(auth relay, file fetching, profile/contacts)PubkyRepo— manages auth state, session lifecycle, profile, and contacts data with all I/O offloaded to background threadsPubkyImagecomponent for loadingpubky://URIs with two-tier (memory + disk) cachingPubkyStoreDataStore caches profile name and image URI for instant display before full profile loadsPubky contacts